Add eslint eol-last to require newline at end of files (#4985)

.eslintrc.json

@@ -22,6 +22,7 @@
     "__DEV__": true
   },
   "rules": {
+    "eol-last": ["error", "always"],
     "global-require": 0,
     "no-undefined": 0,
     "react/display-name": [2, { "ignoreTranspilerName": false }],

app/actions/helpers/channels.ts

@@ -419,4 +419,4 @@ async function getProfilesFromPromises(promises: Array<Promise<ActionResult>>):
     } catch {
         return null;
     }
-}
+}

app/actions/views/emoji.js

@@ -97,4 +97,4 @@ async function getCustomEmojiByName(name) {
     }
 
     return null;
-}
+}

app/actions/views/permalink.ts

@@ -48,4 +48,4 @@ export function closePermalink() {
         showingPermalink = false;
         return dispatch(selectFocusedPostId(''));
     };
-}
+}

app/actions/views/post.test.js

@@ -185,4 +185,4 @@ describe('Actions.Views.Post', () => {
         const receivedStatuses = actionTypes.filter((type) => type === UserTypes.RECEIVED_STATUSES);
         expect(receivedStatuses.length).toBe(1);
     });
-});
+});

app/actions/views/user.js

@@ -242,4 +242,4 @@ export function setCurrentUserStatusOffline() {
 }
 
 /* eslint-disable no-import-assign */
-HelperActions.forceLogoutIfNecessary = forceLogoutIfNecessary;
+HelperActions.forceLogoutIfNecessary = forceLogoutIfNecessary;

app/actions/websocket/channels.test.js

@@ -176,4 +176,4 @@ describe('Websocket Chanel Events', () => {
         const {channels} = store.getState().entities.channels;
         assert.ok(Object.keys(channels).length);
     });
-});
+});

app/actions/websocket/general.test.js

@@ -57,4 +57,4 @@ describe('Websocket General Events', () => {
         assert.ok(config.EnableCustomEmoji === 'true');
         assert.ok(config.EnableLinkPreviews === 'false');
     });
-});
+});

app/actions/websocket/general.ts

@@ -24,4 +24,4 @@ export function handleLicenseChangedEvent(msg: WebSocketMessage): GenericAction
         type: GeneralTypes.CLIENT_LICENSE_RECEIVED,
         data,
     };
-}
+}

app/actions/websocket/groups.ts

@@ -20,4 +20,4 @@ export function handleGroupUpdatedEvent(msg: WebSocketMessage) {
         ]));
         return {data: true};
     };
-}
+}

app/actions/websocket/integrations.test.js

@@ -44,4 +44,4 @@ describe('Websocket Integration Events', () => {
         assert.ok(dialog.trigger_id === 'sometriggerid');
         assert.ok(dialog.dialog);
     });
-});
+});

app/actions/websocket/integrations.ts

@@ -11,4 +11,4 @@ export function handleOpenDialogEvent(msg: WebSocketMessage) {
         dispatch({type: IntegrationTypes.RECEIVED_DIALOG, data: JSON.parse(data)});
         return {data: true};
     };
-}
+}

app/actions/websocket/posts.ts

@@ -206,4 +206,4 @@ export function handlePostUnread(msg: WebSocketMessage) {
 
         return {data: null};
     };
-}
+}

app/actions/websocket/preferences.ts

@@ -57,4 +57,4 @@ export function handlePreferencesDeletedEvent(msg: WebSocketMessage): GenericAct
     const preferences = JSON.parse(msg.data.preferences);
 
     return {type: PreferenceTypes.DELETED_PREFERENCES, data: preferences};
-}
+}

app/actions/websocket/reactions.test.js

@@ -57,4 +57,4 @@ describe('Websocket Reaction Events', () => {
         assert.ok(emojis);
         assert.ok(emojis[created.id]);
     });
-});
+});

app/actions/websocket/reactions.ts

@@ -38,4 +38,4 @@ export function handleReactionRemovedEvent(msg: WebSocketMessage): GenericAction
         type: PostTypes.REACTION_DELETED,
         data: reaction,
     };
-}
+}

app/actions/websocket/roles.ts

@@ -30,4 +30,4 @@ export function handleRoleUpdatedEvent(msg: WebSocketMessage): GenericAction {
         type: RoleTypes.RECEIVED_ROLE,
         data: role,
     };
-}
+}

app/actions/websocket/teams.test.js

@@ -103,4 +103,4 @@ describe('Websocket Team Events', () => {
         const {myMembers} = store.getState().entities.teams;
         assert.ifError(myMembers[team.id]);
     });
-});
+});

app/actions/websocket/teams.ts

@@ -103,4 +103,4 @@ export function handleTeamAddedEvent(msg: WebSocketMessage) {
 
         return {data: true};
     };
-}
+}

app/actions/websocket/users.test.js

@@ -91,4 +91,4 @@ describe('Websocket User Events', () => {
             assert.strictEqual(profiles[user.id].first_name, 'tester4');
         });
     });
-});
+});

app/actions/websocket/users.ts

@@ -202,4 +202,4 @@ export function handleUserUpdatedEvent(msg: WebSocketMessage) {
         }
         return {data: true};
     };
-}
+}

app/components/app_version.tsx

@@ -35,4 +35,4 @@ const AppVersion = () => {
     );
 };
 
-export default AppVersion;
+export default AppVersion;

app/components/at_mention/at_mention.test.js

@@ -41,4 +41,4 @@ describe('AtMention', () => {
         wrapper.setState({user: {username: 'Victor.Welch'}});
         expect(wrapper.getElement()).toMatchSnapshot();
     });
-});
+});

app/components/autocomplete/autocomplete_section_header.js

@@ -75,4 +75,4 @@ AutocompleteSectionHeader.propTypes = {
     isFirstSection: PropTypes.bool,
 };
 
-export default AutocompleteSectionHeader;
+export default AutocompleteSectionHeader;

app/components/autocomplete/emoji_suggestion/emoji_suggestion.test.js

@@ -72,4 +72,4 @@ describe('components/autocomplete/emoji_suggestion', () => {
             expect(wrapper.state('dataSource')).toEqual(output3);
         }, 100);
     });
-});
+});

app/components/channel_loader/channel_loader.test.js

@@ -18,4 +18,4 @@ describe('ChannelLoader', () => {
         const wrapper = shallow(<ChannelLoader {...baseProps}/>);
         expect(wrapper.getElement()).toMatchSnapshot();
     });
-});
+});

app/components/compass_icon/index.js

@@ -4,4 +4,4 @@
 import {createIconSetFromFontello} from 'react-native-vector-icons';
 import fontelloConfig from '@assets/compass-icons.json';
 
-export default createIconSetFromFontello(fontelloConfig, 'compass-icons', 'compass-icons.ttf');
+export default createIconSetFromFontello(fontelloConfig, 'compass-icons', 'compass-icons.ttf');

app/components/deleted_post.js

@@ -79,4 +79,4 @@ const getStyleSheet = makeStyleSheetFromTheme((theme) => {
     };
 });
 
-export default DeletedPost;
+export default DeletedPost;

app/components/edit_channel_info/edit_channel_info.test.js

@@ -91,4 +91,4 @@ describe('EditChannelInfo', () => {
         instance.onKeyboardDidShow();
         expect(instance.scrollHeaderToTop).toHaveBeenCalledTimes(2);
     });
-});
+});

app/components/image_viewport.js

@@ -52,4 +52,4 @@ export default class ImageViewPort extends PureComponent {
     render() {
         return null;
     }
-}
+}

app/components/message_attachments/action_button/action_button.test.js

@@ -125,4 +125,4 @@ describe('ActionButton', () => {
         expect(dynamicButtonStyles).toBe(undefined);
         expect(buttonTextChild.props.style.color).toBe(Preferences.THEMES.default.centerChannelColor);
     });
-});
+});

app/components/message_attachments/action_button/action_button_text.js

@@ -88,4 +88,4 @@ const styles = StyleSheet.create({
 ActionButtonText.propTypes = {
     message: PropTypes.string.isRequired,
     style: PropTypes.object.isRequired,
-};
+};

app/components/message_attachments/action_button/action_button_text.test.js

@@ -140,4 +140,4 @@ describe('ActionButtonText emojis', () => {
             expect(emoticonChild.props.textStyle.fontSize).toBe(12);
         });
     });
-});
+});

app/components/post_attachment_image/index.test.js

@@ -20,4 +20,4 @@ describe('PostAttachmentImage', () => {
 
         expect(wrapper.getElement()).toMatchSnapshot();
     });
-});
+});

app/components/post_body/index.test.js

@@ -120,4 +120,4 @@ describe('makeMapStateToProps', () => {
         mapStateToProps(defaultState, defaultOwnProps);
         expect(canDeletePost).toHaveBeenCalledTimes(1);
     });
-});
+});

app/components/post_draft/archived/archived.js

@@ -103,4 +103,4 @@ const getStyleSheet = makeStyleSheetFromTheme((theme) => ({
         color: 'white',
         fontWeight: 'bold',
     },
-}));
+}));

app/components/post_draft/index.test.js

@@ -117,4 +117,4 @@ describe('mapStateToProps', () => {
             permission: Permissions.USE_CHANNEL_MENTIONS,
         });
     });
-});
+});

app/components/post_draft/quick_actions/camera_quick_action/index.js

@@ -180,4 +180,4 @@ const style = StyleSheet.create({
         justifyContent: 'center',
         padding: 10,
     },
-});
+});

app/components/post_draft/quick_actions/file_quick_action/file_quick_action.test.js

@@ -101,4 +101,4 @@ describe('FileQuickAction', () => {
         expect(request).toHaveBeenCalled();
         expect(hasPermission).toBe(true);
     });
-});
+});

app/components/post_draft/quick_actions/index.js

@@ -17,4 +17,4 @@ function mapStateToProps(state) {
     };
 }
 
-export default connect(mapStateToProps, null, null, {forwardRef: true})(QuickActions);
+export default connect(mapStateToProps, null, null, {forwardRef: true})(QuickActions);

app/components/post_draft/quick_actions/input_quick_action/index.js

@@ -88,4 +88,4 @@ const getStyleSheet = makeStyleSheetFromTheme((theme) => {
             padding: 10,
         },
     };
-});
+});

app/components/post_draft/quick_actions/quick_actions.js

@@ -136,4 +136,4 @@ const style = StyleSheet.create({
         flexDirection: 'row',
         height: 44,
     },
-});
+});

app/components/post_draft/read_only/index.tsx

@@ -67,4 +67,4 @@ const getStyle = makeStyleSheetFromTheme((theme: Theme) => ({
     },
 }));
 
-export default ReadOnlyChannnel;
+export default ReadOnlyChannnel;

app/components/post_header/post_header.test.js

@@ -154,4 +154,4 @@ describe('PostHeader', () => {
         );
         expect(wrapper.getElement()).toMatchSnapshot();
     });
-});
+});

app/components/retry_bar_indicator/retry_bar_indicator.test.js

@@ -53,4 +53,4 @@ describe('RetryBarIndicator', () => {
             expect(Animated.timing).toHaveBeenCalledTimes(1);
         });
     });
-});
+});

app/components/sidebars/drawer_layout/index.tsx

@@ -54,4 +54,4 @@ const DrawerLayoutAdapter = (props: DrawerLayoutAdapterProps) => {
     );
 };
 
-export default DrawerLayoutAdapter;
+export default DrawerLayoutAdapter;

app/components/sidebars/main/main_sidebar_base.js

@@ -307,4 +307,4 @@ const style = StyleSheet.create({
     swiperContent: {
         flex: 1,
     },
-});
+});

app/components/sidebars/settings/settings_sidebar.ios.js

@@ -175,4 +175,4 @@ const getStyleSheet = makeStyleSheetFromTheme((theme) => {
             marginTop: 35,
         },
     };
-});
+});

app/constants/emoji.js

@@ -2,4 +2,4 @@
 // See LICENSE.txt for license information.
 
 export const ALL_EMOJIS = 'all_emojis';
-export const MAX_ALLOWED_REACTIONS = 40;
+export const MAX_ALLOWED_REACTIONS = 40;

app/constants/types.js

@@ -4,4 +4,4 @@
 export default {
     EMPTY_ARRAY: [],
     EMTPY_OBJECT: {},
-};
+};

app/init/fetch.test.js

@@ -85,4 +85,4 @@ describe('Fetch', () => {
         expect(Client4.serverVersion).toEqual(serverVersion1);
         expect(emit).toHaveBeenCalledWith(General.SERVER_VERSION_CHANGED, serverVersion1);
     });
-});
+});

app/init/push_notifications.ts

@@ -251,4 +251,4 @@ class PushNotifications {
     };
 }
 
-export default new PushNotifications();
+export default new PushNotifications();

app/mattermost.test.js

@@ -79,4 +79,4 @@ describe('componentDidDisappearListener', () => {
         expect(EventEmitter.emit).toHaveBeenCalledTimes(1);
         expect(EventEmitter.emit).toHaveBeenCalledWith(NavigationTypes.MAIN_SIDEBAR_DID_CLOSE);
     });
-});
+});

app/mm-redux/constants/roles.ts

@@ -5,4 +5,4 @@ export default {
     MEMBERS: 'members',
     GUESTS: 'guests',
     ADMINS: 'admins',
-};
+};

app/mm-redux/reducers/entities/teams.test.js

@@ -107,4 +107,4 @@ describe('Reducers.teams.myMembers', () => {
         state = teamsReducer(state, testAction);
         assert.deepEqual(state.myMembers, {team_id_1: myMember1});
     });
-});
+});

app/mm-redux/types/bots.ts

@@ -17,4 +17,4 @@ export type BotPatch = {
 	username: string;
 	display_name: string;
     description: string;
-}
+}

app/mm-redux/types/files.ts

@@ -31,4 +31,4 @@ export type FilesState = {
 export type FileUploadResponse = {
     file_infos: FileInfo[];
     client_ids: string[];
-}
+}

app/mm-redux/types/module.d.ts

@@ -4,4 +4,4 @@ declare module 'gfycat-sdk';
 declare module 'remote-redux-devtools';
 declare module 'redux-action-buffer';
 declare module 'react-intl';
-declare module 'react-native-local-auth';
+declare module 'react-native-local-auth';

app/mm-redux/types/preferences.ts

@@ -38,4 +38,4 @@ export type Theme = {
     mentionHighlightBg: string;
     mentionHighlightLink: string;
     codeTheme: string;
-};
+};

app/mm-redux/types/requests.ts

@@ -67,4 +67,4 @@ export type JobsRequestsStatuses = {
 export type SearchRequestsStatuses = {
     flaggedPosts: RequestStatusType;
     pinnedPosts: RequestStatusType;
-};
+};

app/mm-redux/types/search.ts

@@ -30,4 +30,4 @@ export type SearchParameter = {
 	page: number;
 	per_page: number;
 	include_deleted_channels: boolean;
-}
+}

app/mm-redux/types/teams.ts

@@ -55,4 +55,4 @@ export type TeamUnread = {
     team_id: string;
     mention_count: number;
     msg_count: number;
-};
+};

app/mm-redux/types/utilities.ts

@@ -27,4 +27,4 @@ export type EmailMappedObjects<E extends {email: string}> = {
 
 export type Dictionary<T> = {
     [key: string]: T;
-};
+};

app/mm-redux/types/websocket.ts

@@ -15,4 +15,4 @@ export type WebSocketMessage = {
     data: any;
     broadcast: WebsocketBroadcast;
     seq: number;
-}
+}

app/mm-redux/utils/group_utils.test.js

@@ -89,4 +89,4 @@ describe('group utils', () => {
             assert.deepEqual(filterGroupsMatchingTerm(groups, '@software'), [groupC]);
         });
     });
-});
+});

app/reducers/views/recent_emojis.js

@@ -20,4 +20,4 @@ export default function recentEmojis(state = [], action) {
     default:
         return state;
     }
-}
+}

app/screens/channel/channel.android.js

@@ -114,4 +114,4 @@ const style = StyleSheet.create({
     flex: {
         flex: 1,
     },
-});
+});

app/screens/channel/channel.ios.js

@@ -148,4 +148,4 @@ const getStyle = makeStyleSheetFromTheme((theme) => ({
     flex: {
         flex: 1,
     },
-}));
+}));

app/screens/channel/channel_nav_bar/channel_nav_bar.js

@@ -155,4 +155,4 @@ ChannelNavBar.propTypes = {
     theme: PropTypes.object.isRequired,
 };
 
-export default ChannelNavBar;
+export default ChannelNavBar;

app/screens/channel_info/add_members/add_members.test.js

@@ -51,4 +51,4 @@ describe('ChannelInfo -> Add Members', () => {
         );
         expect(wrapper.getElement()).toBeNull();
     });
-});
+});

app/screens/channel_info/archive/archive.test.js

@@ -63,4 +63,4 @@ describe('ChannelInfo -> Archive', () => {
         );
         expect(wrapper.getElement()).toBeNull();
     });
-});
+});

app/screens/channel_info/convert_private/convert_private.test.js

@@ -43,4 +43,4 @@ describe('ChannelInfo -> ConvertPrivate', () => {
         );
         expect(wrapper.getElement()).toBeNull();
     });
-});
+});

app/screens/channel_info/edit_channel/edit_channel.test.js

@@ -41,4 +41,4 @@ describe('ChannelInfo -> EditChannel', () => {
         );
         expect(wrapper.getElement()).toBeNull();
     });
-});
+});

app/screens/channel_info/favorite/favorite.test.js

@@ -43,4 +43,4 @@ describe('ChannelInfo -> Favorite', () => {
         );
         expect(wrapper.getElement()).toMatchSnapshot();
     });
-});
+});

app/screens/channel_info/favorite/favorite.tsx

@@ -40,4 +40,4 @@ const Favorite = ({channelId, favoriteChannel, isFavorite, unfavoriteChannel, te
     );
 };
 
-export default memo(Favorite);
+export default memo(Favorite);

app/screens/channel_info/ignore_mentions/ignore_mentions.test.js

@@ -43,4 +43,4 @@ describe('ChannelInfo -> IgnoreMentions', () => {
         );
         expect(wrapper.getElement()).toMatchSnapshot();
     });
-});
+});

app/screens/channel_info/ignore_mentions/ignore_mentions.tsx

@@ -44,4 +44,4 @@ const IgnoreMentions = ({channelId, ignore, updateChannelNotifyProps, userId, te
     );
 };
 
-export default memo(IgnoreMentions);
+export default memo(IgnoreMentions);

app/screens/channel_info/leave/leave.test.js

@@ -94,4 +94,4 @@ describe('ChannelInfo -> Leave', () => {
         );
         expect(wrapper.getElement()).toBeNull();
     });
-});
+});

app/screens/channel_info/manage_members/manage_members.test.js

@@ -63,4 +63,4 @@ describe('ChannelInfo -> Manage Members', () => {
         );
         expect(wrapper.getElement()).toBeNull();
     });
-});
+});

app/screens/channel_info/mute/mute.test.js

@@ -43,4 +43,4 @@ describe('ChannelInfo -> Mute', () => {
         );
         expect(wrapper.getElement()).toMatchSnapshot();
     });
-});
+});

app/screens/channel_info/mute/mute.tsx

@@ -43,4 +43,4 @@ const Mute = ({channelId, isChannelMuted, updateChannelNotifyProps, userId, test
     );
 };
 
-export default memo(Mute);
+export default memo(Mute);

app/screens/channel_info/pinned/pinned.test.js

@@ -32,4 +32,4 @@ describe('ChannelInfo -> Pinned', () => {
         );
         expect(wrapper.getElement()).toMatchSnapshot();
     });
-});
+});

app/screens/channel_info/separator.tsx

@@ -25,4 +25,4 @@ const getStyleSheet = makeStyleSheetFromTheme((theme: Theme) => ({
     },
 }));
 
-export default Separator;
+export default Separator;

app/screens/channel_members/channel_members.test.js

@@ -56,4 +56,4 @@ describe('ChannelMembers', () => {
         const renderItem = wrapper.find(CustomList).props().renderItem;
         expect(renderItem).toEqual(wrapper.instance().renderSelectableItem);
     });
-});
+});

app/screens/notification/notification_icon.tsx

@@ -90,4 +90,4 @@ const styles = StyleSheet.create({
     },
 });
 
-export default NotificationIcon;
+export default NotificationIcon;

app/screens/notification/notification_title.tsx

@@ -29,4 +29,4 @@ const styles = StyleSheet.create({
     },
 });
 
-export default NotificationTitle;
+export default NotificationTitle;

app/screens/select_server/select_server.test.js

@@ -80,4 +80,4 @@ describe('SelectServer', () => {
         expect(queryByTestId('select_server.error.text')).toBeNull();
         await waitFor(() => expect(getByText('Connecting...')).toBeTruthy());
     });
-});
+});

app/selectors/theme.js

@@ -36,4 +36,4 @@ export const getCustomTheme = createSelector(
         }
         return null;
     },
-);
+);

app/store/helpers.ts

@@ -35,4 +35,4 @@ export async function getStoredState() {
     }
 
     return {storeKeys, restoredState};
-}
+}

app/store/middlewares/index.ts

@@ -32,4 +32,4 @@ export function createMiddlewares(clientOptions: any): ThunkMiddleware[] {
     }
 
     return middleware;
-}
+}

app/store/middlewares/ios_extension.js

@@ -70,4 +70,4 @@ async function saveStateToFile(store) {
 
         mattermostBucket.writeToFile('entities', JSON.stringify(entities));
     }
-}
+}

app/store/middlewares/message_retention.js

@@ -71,4 +71,4 @@ export default function messageRetention(store) {
 
         return next(action);
     };
-}
+}

app/store/store.ts

@@ -14,4 +14,4 @@ class Store {
     }
 }
 
-export default new Store();
+export default new Store();

app/types/push_notification.d.ts

@@ -29,4 +29,4 @@ interface NotificationWithData extends Notification {
     payload?: NotificationData;
     foreground?: boolean;
     userInteraction?: boolean;
-}
+}

app/utils/emoji_utils.js

@@ -173,4 +173,4 @@ export function compareEmojis(emojiA, emojiB, searchedName) {
     }
 
     return doDefaultComparison(aName, bName);
-}
+}

app/utils/message_attachment_colors.js

@@ -10,4 +10,4 @@ export function getStatusColors(theme) {
         primary: theme.buttonBg,
         success: theme.onlineIndicator,
     };
-}
+}

app/utils/preferences.js

@@ -8,4 +8,4 @@ export function buildPreference(category, userId, name, value = 'true') {
         name,
         value,
     };
-}
+}

app/utils/supported_server.ts

@@ -71,4 +71,4 @@ function unsupportedServerAlert(formatMessage: FormatMessageType) {
     const options = {cancelable: false};
 
     Alert.alert(title, message, buttons, options);
-}
+}

jest.config.js

@@ -30,4 +30,4 @@ module.exports = {
     transformIgnorePatterns: [
         'node_modules/(?!react-native|jail-monkey|@sentry/react-native|react-navigation|@react-native-community/cameraroll)',
     ],
-};
+};

packager/moduleNames.js

@@ -36,4 +36,4 @@ module.exports = [
     'app/store/store.ts',
     'app/store/utils.js',
     'share_extension/android/index.js',
-];
+];