From aea93ffbfffdf736cc54eb5ef63dd04c31938ed9 Mon Sep 17 00:00:00 2001 From: Alexander Meindl Date: Sun, 18 Sep 2022 14:43:30 +0200 Subject: [PATCH] refactor render, see https://rails-bestpractices.com/posts/2010/12/04/simplify-render-in-views/ --- app/views/messenger_settings/_show.html.slim | 46 ++++++++++---------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/app/views/messenger_settings/_show.html.slim b/app/views/messenger_settings/_show.html.slim index d8db6ca..5f124fc 100644 --- a/app/views/messenger_settings/_show.html.slim +++ b/app/views/messenger_settings/_show.html.slim @@ -22,56 +22,56 @@ | ( = l :label_messenger_default_not_visible | ) - = render partial: 'messenger_settings/messenger_text', locals: { f: f, mf: :messenger_icon, size: 60 } - = render partial: 'messenger_settings/messenger_text', locals: { f: f, mf: :messenger_channel, size: 30 } - = render partial: 'messenger_settings/messenger_text', locals: { f: f, mf: :messenger_username, size: 30 } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :messenger_verify_ssl } + = render 'messenger_settings/messenger_text', f: f, mf: :messenger_icon, size: 60 + = render 'messenger_settings/messenger_text', f: f, mf: :messenger_channel, size: 30 + = render 'messenger_settings/messenger_text', f: f, mf: :messenger_username, size: 30 + = render 'messenger_settings/messenger_select', f: f, mf: :messenger_verify_ssl fieldset#messenger_settings.box.tabular legend = l :label_issue_plural .info = t :messenger_issue_intro br - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :auto_mentions } - = render partial: 'messenger_settings/messenger_text', locals: { f: f, mf: :default_mentions, size: 30 } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :display_watchers } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_updates } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :new_include_description } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :updated_include_description } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_private_issues } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_private_notes } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :messenger_direct_users_messages } + = render 'messenger_settings/messenger_select', f: f, mf: :auto_mentions + = render 'messenger_settings/messenger_text', f: f, mf: :default_mentions, size: 30 + = render 'messenger_settings/messenger_select', f: f, mf: :display_watchers + = render 'messenger_settings/messenger_select', f: f, mf: :post_updates + = render 'messenger_settings/messenger_select', f: f, mf: :new_include_description + = render 'messenger_settings/messenger_select', f: f, mf: :updated_include_description + = render 'messenger_settings/messenger_select', f: f, mf: :post_private_issues + = render 'messenger_settings/messenger_select', f: f, mf: :post_private_notes + = render 'messenger_settings/messenger_select', f: f, mf: :messenger_direct_users_messages fieldset#messenger_settings.box.tabular legend = l :label_wiki .info = t :messenger_wiki_intro br - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_wiki } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_wiki_updates } + = render 'messenger_settings/messenger_select', f: f, mf: :post_wiki + = render 'messenger_settings/messenger_select', f: f, mf: :post_wiki_updates - if RedmineMessenger::REDMINE_DB_SUPPORT && User.current.allowed_to?(:view_db_entries, @project) fieldset#messenger_settings.box.tabular legend = l :field_db_entries .info = t :messenger_db_intro br - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_db } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_db_updates } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_private_db } + = render 'messenger_settings/messenger_select', f: f, mf: :post_db + = render 'messenger_settings/messenger_select', f: f, mf: :post_db_updates + = render 'messenger_settings/messenger_select', f: f, mf: :post_private_db - if RedmineMessenger::REDMINE_CONTACTS_SUPPORT && User.current.allowed_to?(:view_contacts, @project) fieldset#messenger_settings.box.tabular legend = l :label_contact_plural .info = t :messenger_contacts_intro br - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_contact } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_contact_updates } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_private_contacts } + = render 'messenger_settings/messenger_select', f: f, mf: :post_contact + = render 'messenger_settings/messenger_select', f: f, mf: :post_contact_updates + = render 'messenger_settings/messenger_select', f: f, mf: :post_private_contacts - if Redmine::Plugin.installed?('redmine_passwords') && User.current.allowed_to?(:view_passwords, @project) fieldset#messenger_settings.box.tabular legend = l :label_password_plural .info = t :messenger_passwords_intro br - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_password } - = render partial: 'messenger_settings/messenger_select', locals: { f: f, mf: :post_password_updates } + = render 'messenger_settings/messenger_select', f: f, mf: :post_password + = render 'messenger_settings/messenger_select', f: f, mf: :post_password_updates = submit_tag l(:button_save)