From 4373a7c410f9df30e4e5968aea7ca0a54d4fc62f Mon Sep 17 00:00:00 2001 From: Alexander Meindl Date: Thu, 13 Jan 2022 18:11:18 +0100 Subject: [PATCH] Use bulk for migration --- .rubocop.yml | 6 ++++++ db/migrate/003_add_private_settings.rb | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 7efa2c6..1d6ed88 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -67,6 +67,12 @@ Style/OptionHash: Exclude: - lib/redmine_messenger/patches/*.rb +# postgresql and mysql are supported +# autodetect does not work without database configuration +Rails/BulkChangeTable: + Enabled: true + Database: postgresql + Style/ReturnNil: Enabled: true diff --git a/db/migrate/003_add_private_settings.rb b/db/migrate/003_add_private_settings.rb index b24eeee..288898b 100644 --- a/db/migrate/003_add_private_settings.rb +++ b/db/migrate/003_add_private_settings.rb @@ -2,7 +2,9 @@ class AddPrivateSettings < ActiveRecord::Migration[4.2] def change - add_column :messenger_settings, :post_private_contacts, :integer, default: 0, null: false - add_column :messenger_settings, :post_private_db, :integer, default: 0, null: false + change_table :messenger_settings, bulk: true do |t| + t.integer :post_private_contacts, default: 0, null: false + t.integer :post_private_db, default: 0, null: false + end end end