Some code cleanups

lib/redmine_messenger.rb

@@ -10,6 +10,10 @@ Rails.configuration.to_prepare do
     def self.settings
       ActionController::Parameters.new(Setting[:plugin_redmine_messenger])
     end
+
+    def setting?(value)
+      return true if settings[value].to_i == 1
+    end
   end
 
   # Patches

lib/redmine_messenger/helpers.rb

@@ -3,9 +3,9 @@
 module RedmineMessenger
   module Helpers
     def project_messenger_options(active)
-      options_for_select({ l(:label_messenger_settings_default) => 0,
-                           l(:label_messenger_settings_disabled) => 1,
-                           l(:label_messenger_settings_enabled) => 2 }, active)
+      options_for_select({ l(:label_messenger_settings_default) => '0',
+                           l(:label_messenger_settings_disabled) => '1',
+                           l(:label_messenger_settings_enabled) => '2' }, active)
     end
 
     def project_setting_messenger_default_value(value)

lib/redmine_messenger/patches/issue_patch.rb

@@ -39,7 +39,7 @@ module RedmineMessenger
             short: true
           }]
 
-          if RedmineMessenger.settings[:display_watchers] == '1'
+          if RedmineMessenger.setting?(:display_watchers)
             attachment[:fields] << {
               title: I18n.t(:field_watcher),
               value: ERB::Util.html_escape(watcher_users.join(', ')),