SW/openwrt
2
0
Fork 0
forked from Ivasoft/openwrt
Code Pull Requests Activity

bcm63xx: pinctrl: fix BCM6348 groups

Browse Source 
The current driver has some troubles:
 - Some groupings are wrong.
 - The pinctrl group0 owns pins never used (at least in Openwrt) for any
   pinmux. The driver hijacks all the pins on the group avoiding any other
   use, spite they're free. I.e. for buttons, causing this kernel error:
   [  4.735928] gpio-keys-polled keys: unable to claim gpio 479, err=-22
   [  4.742642] gpio-keys-polled: probe of keys failed with error -22
 - Minor errors about groupings on the documentation
 - Missing "diag" grouping in dtsi
 - Wrong groupings in dtsi

Fix it by setting the correct groups.
And relax the pin capturing, letting the gpios belonging to any group to
be used for other purposes like buttons. This was the behavior with stock
firmwares and old OpenWrt versions which never caused any trouble.

Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
This commit is contained in:
Daniel González Cabanelas
2020-05-19 15:56:29 +02:00
committed by Álvaro Fernández Rojas
parent 09bbf55817
commit 50cb3a750f
5 changed files with 21 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
target/linux/bcm63xx/dts/bcm6348.dtsi
View File

@@ -94,7 +94,7 @@
};
pinctrl_mii_snoop: mii_snoop {
function = "ext_ephy";
function = "mii_snoop";
groups = "group1", "group4";
};
@@ -125,7 +125,12 @@
pinctrl_utopia: utopia {
function = "utopia";
groups = "group0", "group1", "group3";
groups = "group1", "group3", "group4";
};
pinctrl_diag: diag {
function = "diag";
groups = "group0", "group1", "group2", "group3", "group4";
};
};