forked from Ivasoft/openwrt
package/*: remove useless explicit set of function returncode
somebody started to set a function returncode in the validation
stuff and everybody copies it, e.g.
myfunction()
{
fire_command
return $?
}
a function automatically returns with the last returncode,
so we can safely remove the command 'return $?'. reference:
http://tldp.org/LDP/abs/html/exit-status.html
"The last command executed in the function or script determines the exit status."
Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>
SVN-Revision: 42278
This commit is contained in:
@@ -15,8 +15,6 @@ validate_firewall_redirect()
|
||||
'dest_ip:cidr' \
|
||||
'dest_port:or(port, portrange)' \
|
||||
'target:or("SNAT", "DNAT")'
|
||||
|
||||
return $?
|
||||
}
|
||||
|
||||
validate_firewall_rule()
|
||||
@@ -28,8 +26,6 @@ validate_firewall_rule()
|
||||
'src_port:or(port, portrange)' \
|
||||
'dest_port:or(port, portrange)' \
|
||||
'target:string'
|
||||
|
||||
return $?
|
||||
}
|
||||
|
||||
service_triggers() {
|
||||
|
||||
Reference in New Issue
Block a user