Files
mattermost-mobile/app/database/admin/data_operator/test.ts
Avinash Lingaloo d6a3504c08 MM_30482 [v2] DataOperator for all the isolated tables (#5182)
* MM_30475 : ADDED default schema

* MM_30475 : ADDED todo for field 'value' of default/Global entity

* MM_30476 : Created schema for SERVER DB

* MM_30476 : Server model [ IN PROGRESS ]

* MM_30476 : Including types for group, groups_in_channel and role

* MM_30476 : ADDED models for Group

- @typings absolute path has been added to the tsconfig.json

* MM_30476 : ADDED typings to current models

* MM_30476 : ADDED typings to current models

* MM_30476 : ADDED models related to TEAM section of the ERD

* MM_30476 : ADDED models for User section of the ERD

* MM_30476 : ADDED models for POST section of the ERD

* MM_30476 : ADDED models for Channel section of the ERD

* MM_30475 : Updated typings and references to MM_TABLES

* MM_30476 : Verified all field names

* MM_30476 : Verified every table associations

* MM_30476 : Verified all relation fields

* MM_30476 : Updated primary id of the main models

We will override the wdb id at component level when we create a new records.  This involves the models : channel, group, post, team and user.

* MM_30476 : Including 1:1 relationship amongs some entities

* MM_30476 : ADDED Schema Managers

* The migration array will hold all the migration steps.

*  The initial app release (e.g. v2 )will have an empty array and subsequent releases  (e.g.  v2.1 ) will have the steps listed in that array.

* On initialization, the database will perform the migration to accomodate for new columns/tables creation and while it will conserve the mobile phone's data, it will also make it conform to this new schema.

* If a migration fails, the migration process will rollback any changes.  This migration will be thoroughly tested in development before pushing it live.

* Revert "MM_30476 : ADDED Schema Managers"

This reverts commit a505bd5e11.

* MM_30478 : Converted schema_manager into a function

* MM_30478 : Updated schema manager and included patch for wdb

* MM_30478:  Updated watermelondb patch package

* MM_30478 : Update function create_schema_manager to createSqliteAdaptorOptions

* MM_30476 : Update constant name to reflect directory name

* MM_30476 : Updated msgCount from my_channel model to message_count in server schema

* MM_30482 : Added tests for schema_manager

* MM_30482 : Database Manager [ IN PROGRESS ]

* MM_30478 : Returning an sqliteAdapter instead of an object

* MM_30476 : Apply suggestions from code review

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>

* MM_30476 : Updated all imports as per instruction.

* MM_30476 : Shortening object chains by destructuring

* MM_30476 : Updated schema file structure

* MM_30476 : Prettifying @typings folder

* MM_30476 : Removing useless ids

* MM_30476 : Prettify imports for decorators

* MM_30476 : ADDED documentations and lazy queries to Channel and Channel_Info

* MM_30476 : ADDED documentations for default schema

* MM_30476 : Documentation [ IN PROGRESS ]

- Following JSDoc syntax for single line comment
- Removed redundant fields in the 'membership' tables and left only the @relation records.

* MM_30476 : Documentations [ IN PROGRESS ]

* MM_30476 : Documentations [ IN PROGRESS ]

* MM_30476 : Documentations [ IN PROGRESS ]

* MM_30476 : Documentations [ IN PROGRESS]

Updated
1)  my_team and team,
2) my_channel and  channel,

to each have 1:1 relationship  with one another

* MM_30476 : Updated all Typescript definitions

* MM_30476 :Updated @relation to @immutableRelation

* MM_30476 : Updated description for previous_post_id

* MM_30478 : Updated patch package for wdb module

* MM_30478: DB Manager [IN PROGRESS ]

* MM_30478: DB Manager [IN PROGRESS]

* MM_30478: DB Manager [IN PROGRESS]

* MM_30478 : DB Manager [IN PROGRESS]

* MM_30478 : Deleting .db file on iOS

* MM_30478: Successfully deleting .db files and directory on iOS side

* MM_30478 : Update definition for default/global

* MM_30478 : Updated all models

* MM_30478 : Doing a bit of house cleaning

* MM_30478: Record of new server connection  added to default/servers db

* TS Definitely Typed Assignment issue is now FIXED

* MM_30478 : TS Definitely Typed Assignment \n  Removed all the constructors but error still in editor tabs.  But this time the app is not crashing

* MM_30478 : Attempt 1 [SUCCESSFUL]

* MM_30478 : Removing useDefineForClassFields

* MM_30478 : Retrieving the servers in a list + Improved the DB Manager and Babel config

* MM_30478 : Updated babel.config.js

* MM_30478 : Minor UI correction

* MM_30478 : Jest and Typescript configuration

* MM_30478 : A bit of housekeeping

* MM_30478 : Installed WDB on Android

* MM_30478 : Deletes new server record from default DB

* MM_30478 : Returns subset of server db instances

* MM_30478 : Code clean up

* MM_30478 :  Code clean up on db manager

* MM_30478 : House keeping + Patch for WDB

* MM_30478 : Android - Saving & Deleting in FilesDir [COMPLETED]

* MM_30478 : Code clean up

* MM_30478 : Code clean up

* MM_30478 : Code clean up

* MM_30478 : Test successful on Android device

* MM_30478 : Rolling back change to jest.config.js

* MM_30478 : Updated test to test_integration

* MM_30478 : Fix imports

* MM_30478 : Refactored the manual testscript

* MM_30478 : Renamed database manager test file

* MM_30478 : Code clean up

* MM_30478 : Updated manual test file with a note.

* MM_30482 : DataOperator [ IN PROGRESS ]

* MM_30482 : DataOperator - setting up the factory [ IN PROGRESS ]

* MM_30482: Code refactoring

* MM_30482 : DataOperator - setting up the factory [ IN PROGRESS ]

* MM_30482 : DataOperator - code clean up [ IN PROGRESS ]

* MM_30482 : Minor code clean up

* MM_30478 : Fixed JEST issue with TS

* MM_30478 : Fixed JEST issue with TS

* MM_30478 : Fixed JEST issue with TS

* MM_30478 : Implementing JEST test cases

* MM_30478 : Implementing JEST last  test cases

* MM_30478 : Jest fixing ts errors

* MM_30478 : Database Manager Jest testing [ IN PROGRESS ]

* MM_30482 - Fixing DataOperator [ IN PROGRESS ]

* MM_30482 : Code clean up

* MM_30482 - Creates multiple records [ IN PROGRESS ]

* MM_30482 - Creates multiple records [ IN PROGRESS ]

* MM_30482 : Update operation [ COMPLETED ]

* MM_30482 : Code clean up

* MM_30482 : Updated TS for Data Operator

* Update mobile v2 detox deps

* MM_30482 : Added factories for all isolated tables

* MM_30482 : Refactored TS

* MM_30482 : Refactored base factory

* MM_30482 : Updated JSDoc for operateBaseRecord - Delete CASE

* MM_30482 : Implementing test for Data Operator

* MM_30482 : Completed tests for all isolated tables

* MM_30482 : Renamed entity_factory into operators

* MM_30482 : Fix all imports

* MM_30482 : Update multiple records

* MM_30482 : Edge case for existing records ( update instead of create )

* MM_30482 : Edge case  - create instead of update

* MM_30482 : Code clean up

* MM_30482 : Code clean up

* MM_30482 : Code clean up

* MM_30482 : Code clean up

* Update app/database/admin/data_operator/operators.ts

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>

* Update app/database/admin/data_operator/operators.ts

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>

* Update app/database/admin/data_operator/operators.ts

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>

* MM_30482 : Imposing usage of correct table name for isolated entities

* MM_30482 : Code improvement as per Joseph reviews

* MM_30482 : Updated tests to validate choice of operator service wrt tableName

* MM_30482 : Updated PR as per suggestions

* MM_30482 : Updated comments to follow jsdoc conventions

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
Co-authored-by: Avinash Lingaloo <>
Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>
2021-02-26 08:24:53 +04:00

482 lines
18 KiB
TypeScript

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {MM_TABLES} from '@constants/database';
import {Q} from '@nozbe/watermelondb';
import App from '@typings/database/app';
import DatabaseManager, {DatabaseType} from '../database_manager';
import DataOperator, {IsolatedEntities, OperationType} from './index';
import {
operateAppRecord,
operateCustomEmojiRecord,
operateGlobalRecord,
operateRoleRecord,
operateServersRecord,
operateSystemRecord,
operateTermsOfServiceRecord,
} from './operators';
jest.mock('../database_manager');
const {APP} = MM_TABLES.DEFAULT;
describe('*** Data Operator tests ***', () => {
it('=> should return an array of type App for operateAppRecord', async () => {
expect.assertions(3);
const db = await DatabaseManager.getDefaultDatabase();
expect(db).toBeTruthy();
const preparedRecords = await operateAppRecord({
db: db!,
optType: OperationType.CREATE,
value: {buildNumber: 'build-7', createdAt: 1, id: 'id-18', versionNumber: 'v-1'},
});
expect(preparedRecords).toBeTruthy();
expect(preparedRecords!.collection.modelClass.name).toMatch('App');
});
it('=> should return an array of type Global for operateGlobalRecord', async () => {
expect.assertions(3);
const db = await DatabaseManager.getDefaultDatabase();
expect(db).toBeTruthy();
const preparedRecords = await operateGlobalRecord({
db: db!,
optType: OperationType.CREATE,
value: {id: 'g-1', name: 'g-n1', value: 'g-v1'},
});
expect(preparedRecords).toBeTruthy();
expect(preparedRecords!.collection.modelClass.name).toMatch('Global');
});
it('=> should return an array of type Servers for operateServersRecord', async () => {
expect.assertions(3);
const db = await DatabaseManager.getDefaultDatabase();
expect(db).toBeTruthy();
const preparedRecords = await operateServersRecord({
db: db!,
optType: OperationType.CREATE,
value: {
dbPath: 'mm-server',
displayName: 's-displayName',
id: 's-1',
mentionCount: 1,
unreadCount: 0,
url: 'https://community.mattermost.com',
},
});
expect(preparedRecords).toBeTruthy();
expect(preparedRecords!.collection.modelClass.name).toMatch('Servers');
});
it('=> should return an array of type CustomEmoji for operateCustomEmojiRecord', async () => {
expect.assertions(3);
const db = await DatabaseManager.createDatabaseConnection({
shouldAddToDefaultDatabase: true,
databaseConnection: {
actionsEnabled: true,
dbName: 'community mattermost',
dbType: DatabaseType.SERVER,
serverUrl: 'https://appv2.mattermost.com',
},
});
expect(db).toBeTruthy();
const preparedRecords = await operateCustomEmojiRecord({
db: db!,
optType: OperationType.CREATE,
value: {id: 'emo-1', name: 'emoji'},
});
expect(preparedRecords).toBeTruthy();
expect(preparedRecords!.collection.modelClass.name).toMatch('CustomEmoji');
});
it('=> should return an array of type Role for operateRoleRecord', async () => {
expect.assertions(3);
const db = await DatabaseManager.createDatabaseConnection({
shouldAddToDefaultDatabase: true,
databaseConnection: {
actionsEnabled: true,
dbName: 'community mattermost',
dbType: DatabaseType.SERVER,
serverUrl: 'https://appv2.mattermost.com',
},
});
expect(db).toBeTruthy();
const preparedRecords = await operateRoleRecord({
db: db!,
optType: OperationType.CREATE,
value: {id: 'role-1', name: 'role-name-1', permissions: []},
});
expect(preparedRecords).toBeTruthy();
expect(preparedRecords!.collection.modelClass.name).toMatch('Role');
});
it('=> should return an array of type System for operateSystemRecord', async () => {
expect.assertions(3);
const db = await DatabaseManager.createDatabaseConnection({
shouldAddToDefaultDatabase: true,
databaseConnection: {
actionsEnabled: true,
dbName: 'community mattermost',
dbType: DatabaseType.SERVER,
serverUrl: 'https://appv2.mattermost.com',
},
});
expect(db).toBeTruthy();
const preparedRecords = await operateSystemRecord({
db: db!,
optType: OperationType.CREATE,
value: {id: 'system-1', name: 'system-name-1', value: 'system'},
});
expect(preparedRecords).toBeTruthy();
expect(preparedRecords!.collection.modelClass.name).toMatch('System');
});
it('=> should return an array of type TermsOfService for operateTermsOfServiceRecord', async () => {
expect.assertions(3);
const db = await DatabaseManager.createDatabaseConnection({
shouldAddToDefaultDatabase: true,
databaseConnection: {
actionsEnabled: true,
dbName: 'community mattermost',
dbType: DatabaseType.SERVER,
serverUrl: 'https://appv2.mattermost.com',
},
});
expect(db).toBeTruthy();
const preparedRecords = await operateTermsOfServiceRecord({
db: db!,
optType: OperationType.CREATE,
value: {id: 'system-1', acceptedAt: 1},
});
expect(preparedRecords).toBeTruthy();
expect(preparedRecords!.collection.modelClass.name).toMatch('TermsOfService');
});
it('=> should create a record in the App table in the default database', async () => {
expect.assertions(2);
// Creates a record in the App table
await DataOperator.handleIsolatedEntityData({
optType: OperationType.CREATE,
tableName: IsolatedEntities.APP,
values: {buildNumber: 'build-1', createdAt: 1, id: 'id-1', versionNumber: 'version-1'},
});
// Do a query and find out if the value has been registered in the App table of the default database
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const records = await defaultDB!.collections.get(APP).query(Q.where('id', 'id-1')).fetch() as App[];
// We should expect to have a record returned as dictated by our query
expect(records.length).toBe(1);
});
it('=> should create several records in the App table in the default database', async () => {
expect.assertions(2);
// Creates a record in the App table
await DataOperator.handleIsolatedEntityData({
optType: OperationType.CREATE,
tableName: IsolatedEntities.APP,
values: [
{buildNumber: 'build-10', createdAt: 1, id: 'id-10', versionNumber: 'version-10'},
{buildNumber: 'build-11', createdAt: 1, id: 'id-11', versionNumber: 'version-11'},
{buildNumber: 'build-12', createdAt: 1, id: 'id-12', versionNumber: 'version-12'},
{buildNumber: 'build-13', createdAt: 1, id: 'id-13', versionNumber: 'version-13'},
],
});
// Do a query and find out if the value has been registered in the App table of the default database
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const records = await defaultDB!.collections.get(APP).query(Q.where('id', Q.oneOf(['id-10', 'id-11', 'id-12', 'id-13']))).fetch() as App[];
// We should expect to have 4 records created
expect(records.length).toBe(4);
});
it('=> should update a record in the App table in the default database', async () => {
expect.assertions(3);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
// Update record having id 'id-1'
await DataOperator.handleIsolatedEntityData({
optType: OperationType.UPDATE,
tableName: IsolatedEntities.APP,
values: {buildNumber: 'build-13-13', createdAt: 1, id: 'id-1', versionNumber: 'version-1'},
});
const records = await defaultDB!.collections.get(APP).query(Q.where('id', 'id-1')).fetch() as App[];
expect(records.length).toBeGreaterThan(0);
// Verify if the buildNumber for this record has been updated
expect(records[0].buildNumber).toMatch('build-13-13');
});
it('=> should update several records in the App table in the default database', async () => {
expect.assertions(4);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
// Update records having id 'id-10' and 'id-11'
await DataOperator.handleIsolatedEntityData({
optType: OperationType.UPDATE,
tableName: IsolatedEntities.APP,
values: [
{buildNumber: 'build-10x', createdAt: 1, id: 'id-10', versionNumber: 'version-10'},
{buildNumber: 'build-11y', createdAt: 1, id: 'id-11', versionNumber: 'version-11'},
],
});
const records = await defaultDB!.collections.get(APP).query(Q.where('id', Q.oneOf(['id-10', 'id-11']))).fetch() as App[];
expect(records.length).toBe(2);
// Verify if the buildNumber for those two record has been updated
expect(records[0].buildNumber).toMatch('build-10x');
expect(records[1].buildNumber).toMatch('build-11y');
});
it('=> [EDGE CASE] should UPDATE instead of CREATE record for existing id', async () => {
expect.assertions(3);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
// id-10 and id-11 exist but yet the optType is CREATE. The operator should then prepareUpdate the records instead of prepareCreate
await DataOperator.handleIsolatedEntityData({
optType: OperationType.CREATE,
tableName: IsolatedEntities.APP,
values: [
{buildNumber: 'build-10x', createdAt: 1, id: 'id-10', versionNumber: 'version-10'},
{buildNumber: 'build-11x', createdAt: 1, id: 'id-11', versionNumber: 'version-11'},
],
});
const records = await defaultDB!.collections.get(APP).query(Q.where('id', Q.oneOf(['id-10', 'id-11']))).fetch() as App[];
// Verify if the buildNumber for those two record has been updated
expect(records[0].buildNumber).toMatch('build-10x');
expect(records[1].buildNumber).toMatch('build-11x');
});
it('=> [EDGE CASE] should CREATE instead of UPDATE record for non-existing id', async () => {
expect.assertions(3);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
// id-15 and id-16 do not exist but yet the optType is UPDATE. The operator should then prepareCreate the records instead of prepareUpdate
await DataOperator.handleIsolatedEntityData({
optType: OperationType.UPDATE,
tableName: IsolatedEntities.APP,
values: [
{buildNumber: 'build-10x', createdAt: 1, id: 'id-15', versionNumber: 'version-10'},
{buildNumber: 'build-11x', createdAt: 1, id: 'id-16', versionNumber: 'version-11'},
],
});
const records = await defaultDB!.collections.get(APP).query(Q.where('id', Q.oneOf(['id-15', 'id-16']))).fetch() as App[];
// Verify if the buildNumber for those two record has been created
expect(records[0].buildNumber).toMatch('build-10x');
expect(records[1].buildNumber).toMatch('build-11x');
});
it('=> should use operateAppRecord for APP entity in handleBaseData', async () => {
expect.assertions(2);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const spyOnHandleBase = jest.spyOn(DataOperator as any, 'handleBaseData');
const data = {
optType: OperationType.CREATE,
tableName: IsolatedEntities.APP,
values: [
{buildNumber: 'build-10x', createdAt: 1, id: 'id-21', versionNumber: 'version-10'},
{buildNumber: 'build-11y', createdAt: 1, id: 'id-22', versionNumber: 'version-11'},
],
};
await DataOperator.handleIsolatedEntityData(data);
expect(spyOnHandleBase).toHaveBeenCalledWith({...data, recordOperator: operateAppRecord});
});
it('=> should use operateGlobalRecord for GLOBAL entity in handleBaseData', async () => {
expect.assertions(2);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const spyOnHandleBase = jest.spyOn(DataOperator as any, 'handleBaseData');
const data = {
optType: OperationType.CREATE,
tableName: IsolatedEntities.GLOBAL,
values: {id: 'global-1-id', name: 'global-1-name', value: 'global-1-value'},
};
await DataOperator.handleIsolatedEntityData(data);
expect(spyOnHandleBase).toHaveBeenCalledWith({...data, recordOperator: operateGlobalRecord});
});
it('=> should use operateServersRecord for SERVERS entity in handleBaseData', async () => {
expect.assertions(2);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const spyOnHandleBase = jest.spyOn(DataOperator as any, 'handleBaseData');
const data = {
optType: OperationType.CREATE,
tableName: IsolatedEntities.SERVERS,
values: {
dbPath: 'server.db',
displayName: 'community',
id: 'server-id-1',
mentionCount: 0,
unreadCount: 0,
url: 'https://community.mattermost.com',
},
};
await DataOperator.handleIsolatedEntityData(data);
expect(spyOnHandleBase).toHaveBeenCalledWith({...data, recordOperator: operateServersRecord});
});
it('=> should use operateCustomEmojiRecord for CUSTOM_EMOJI entity in handleBaseData', async () => {
expect.assertions(2);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const spyOnHandleBase = jest.spyOn(DataOperator as any, 'handleBaseData');
const data = {
optType: OperationType.CREATE,
tableName: IsolatedEntities.CUSTOM_EMOJI,
values: {
id: 'custom-emoji-id-1',
name: 'custom-emoji-1',
},
};
await DataOperator.handleIsolatedEntityData(data);
expect(spyOnHandleBase).toHaveBeenCalledWith({...data, recordOperator: operateCustomEmojiRecord});
});
it('=> should use operateRoleRecord for ROLE entity in handleBaseData', async () => {
expect.assertions(2);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const spyOnHandleBase = jest.spyOn(DataOperator as any, 'handleBaseData');
const data = {
optType: OperationType.CREATE,
tableName: IsolatedEntities.ROLE,
values: {
id: 'custom-emoji-id-1',
name: 'custom-emoji-1',
permissions: ['custom-emoji-1'],
},
};
await DataOperator.handleIsolatedEntityData(data);
expect(spyOnHandleBase).toHaveBeenCalledWith({...data, recordOperator: operateRoleRecord});
});
it('=> should use operateSystemRecord for SYSTEM entity in handleBaseData', async () => {
expect.assertions(2);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const spyOnHandleBase = jest.spyOn(DataOperator as any, 'handleBaseData');
const data = {
optType: OperationType.CREATE,
tableName: IsolatedEntities.SYSTEM,
values: {id: 'system-id-1', name: 'system-1', value: 'system-1'},
};
await DataOperator.handleIsolatedEntityData(data);
expect(spyOnHandleBase).toHaveBeenCalledWith({...data, recordOperator: operateSystemRecord});
});
it('=> should use operateTermsOfServiceRecord for TERMS_OF_SERVICE entity in handleBaseData', async () => {
expect.assertions(2);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const spyOnHandleBase = jest.spyOn(DataOperator as any, 'handleBaseData');
const data = {
optType: OperationType.CREATE,
tableName: IsolatedEntities.TERMS_OF_SERVICE,
values: {id: 'tos-1', acceptedAt: 1},
};
await DataOperator.handleIsolatedEntityData(data);
expect(spyOnHandleBase).toHaveBeenCalledWith({...data, recordOperator: operateTermsOfServiceRecord});
});
it('=> should not call handleBaseData if tableName is invalid', async () => {
expect.assertions(2);
const defaultDB = await DatabaseManager.getDefaultDatabase();
expect(defaultDB).toBeTruthy();
const spyOnHandleBase = jest.spyOn(DataOperator as any, 'handleBaseData');
const data = {
optType: OperationType.CREATE,
tableName: 'INVALID_TABLE_NAME',
values: {id: 'tos-1', acceptedAt: 1},
};
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
await DataOperator.handleIsolatedEntityData(data);
expect(spyOnHandleBase).toHaveBeenCalledTimes(0);
});
});