From 569f66908e35dae10a447e50e973fc442e921918 Mon Sep 17 00:00:00 2001 From: Mustafa Kara Date: Tue, 7 Jun 2022 17:44:31 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Amy Blais <29708087+amyblais@users.noreply.github.com> --- build/notice-file/Readme.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/build/notice-file/Readme.md b/build/notice-file/Readme.md index 61a6a68dcc..abb4a8f866 100644 --- a/build/notice-file/Readme.md +++ b/build/notice-file/Readme.md @@ -5,14 +5,14 @@ We are automatically generating Notice.txt by using first-level dependencies of ## Configuration -Notice.txt will be always generated from first level dependencies scanned from package.json files. For some cases it may be useful to define -dependency to add it's licence to the Notice.txt even if it is not first level dependency or development dependency. +Notice.txt will be always generated from first-level dependencies scanned from package.json files. For some cases it may be useful to define the +dependency to add its licence to the Notice.txt even if it is not first-level dependency or development dependency. -For instance at desktop project we need to add `wix`'s licence to the Notice.txt even if it is not a first level dependency. To do that define +For instance at desktop project we need to add `wix`'s licence to the Notice.txt even if it is not a first-level dependency. To do that, define all dependencies at `dependencies` array at the configuration. For any dependency at `dependencies` section, pipeline code will add their licenses to the Notice.txt file. -At webapp project `webpack` used in `devDependencies` and it is requested because we are using some files generated by `webpack`. If any dependency +At webapp project `webpack` used in `devDependencies`, it is requested because we are using some files generated by `webpack`. If any dependency is referenced at `devDependencies` section, pipeline will add those dependency licences when they are referenced at `package.json` files. Sample: