From 336aeedd4ae51ba655e427aa361853bdfb0fcddc Mon Sep 17 00:00:00 2001 From: Elias Nahum Date: Tue, 26 Apr 2022 07:45:12 -0400 Subject: [PATCH] Remove logError remote action (#6193) --- app/actions/remote/error.ts | 39 ----------------------------------- app/actions/remote/session.ts | 2 -- app/actions/remote/systems.ts | 3 --- 3 files changed, 44 deletions(-) delete mode 100644 app/actions/remote/error.ts diff --git a/app/actions/remote/error.ts b/app/actions/remote/error.ts deleted file mode 100644 index 52adbeb512..0000000000 --- a/app/actions/remote/error.ts +++ /dev/null @@ -1,39 +0,0 @@ -// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved. -// See LICENSE.txt for license information. - -//fixme: to be completed in next PR. - -// eslint-disable-next-line @typescript-eslint/no-unused-vars -export const logError = (_e: any) => null; - -// export const logError = async (error: Error, displayable = false) => { -// if (error?.server_error_id === 'api.context.session_expired.app_error') { -// return {data: true}; -// } -// -// const serializedError = serializeError(error); -// -// let sendToServer = true; -// if (error.stack && error.stack.includes('TypeError: Failed to fetch')) { -// sendToServer = false; -// } -// if (error?.server_error_id) { -// sendToServer = false; -// } -// -// if (sendToServer) { -// try { -// const stringifiedSerializedError = JSON.stringify(serializedError).toString(); -// await Client4.logClientError(stringifiedSerializedError); -// } catch (err) { -// // avoid crashing the app if an error sending -// // the error occurs. -// } -// } -// -// EventEmitter.emit(ErrorTypes.LOG_ERROR, error); -// dispatch(getLogErrorAction(serializedError, displayable)); - -// return {data: true}; -// }; - diff --git a/app/actions/remote/session.ts b/app/actions/remote/session.ts index f0f1cf5046..0f9c8ff070 100644 --- a/app/actions/remote/session.ts +++ b/app/actions/remote/session.ts @@ -15,7 +15,6 @@ import {getCurrentUserId, getCommonSystemValues} from '@queries/servers/system'; import {getCSRFFromCookie} from '@utils/security'; import {loginEntry} from './entry'; -import {logError} from './error'; import {fetchDataRetentionPolicy} from './systems'; import {autoUpdateTimezone} from './user'; @@ -89,7 +88,6 @@ export const getSessions = async (serverUrl: string, currentUserId: string) => { try { return await client.getSessions(currentUserId); } catch (e) { - logError(e); await forceLogoutIfNecessary(serverUrl, e as ClientError); } diff --git a/app/actions/remote/systems.ts b/app/actions/remote/systems.ts index 2a1cf5f5de..a507dcf8e9 100644 --- a/app/actions/remote/systems.ts +++ b/app/actions/remote/systems.ts @@ -3,7 +3,6 @@ import deepEqual from 'deep-equal'; -import {logError} from '@actions/remote/error'; import {forceLogoutIfNecessary} from '@actions/remote/session'; import {SYSTEM_IDENTIFIERS} from '@constants/database'; import DatabaseManager from '@database/manager'; @@ -32,8 +31,6 @@ export const fetchDataRetentionPolicy = async (serverUrl: string) => { data = await client.getDataRetentionPolicy(); } catch (error) { forceLogoutIfNecessary(serverUrl, error as ClientError); - - logError(error); return {error}; }