SW/mattermost-mobile
2
0
Fork 0
forked from Ivasoft/mattermost-mobile
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Gekidou] operator handlers improvements (#6136)

Browse Source 
* Allow database operator handlers to deal with empty or undefined input values

* Prevent known handler warnings

* Update app/database/operator/server_data_operator/handlers/post.ts

Co-authored-by: Avinash Lingaloo <avinashlng1080@gmail.com>

* feedback review

* remove unnecessary !

Co-authored-by: Avinash Lingaloo <avinashlng1080@gmail.com>
This commit is contained in:
Elias Nahum
2022-04-07 09:17:57 -04:00
committed by GitHub
parent 3326f34933
commit 0950dbd21b
41 changed files with 334 additions and 369 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
app/database/operator/app_data_operator/index.ts
View File

@@ -2,7 +2,6 @@
// See LICENSE.txt for license information.
import {MM_TABLES} from '@constants/database';
import DataOperatorException from '@database/exceptions/data_operator_exception';
import {buildAppInfoKey} from '@database/operator/app_data_operator/comparator';
import {transformInfoRecord, transformGlobalRecord} from '@database/operator/app_data_operator/transformers';
import BaseDataOperator from '@database/operator/base_data_operator';
@@ -13,11 +12,13 @@ import type {HandleInfoArgs, HandleGlobalArgs} from '@typings/database/database'
const {APP: {INFO, GLOBAL}} = MM_TABLES;
export default class AppDataOperator extends BaseDataOperator {
handleInfo = ({info, prepareRecordsOnly = true}: HandleInfoArgs) => {
if (!info.length) {
throw new DataOperatorException(
'An empty "values" array has been passed to the handleInfo',
handleInfo = async ({info, prepareRecordsOnly = true}: HandleInfoArgs) => {
if (!info?.length) {
// eslint-disable-next-line no-console
console.warn(
'An empty or undefined "info" array has been passed to the handleInfo',
);
return [];
}
return this.handleRecords({
@@ -30,18 +31,20 @@ export default class AppDataOperator extends BaseDataOperator {
});
};
handleGlobal = async ({global, prepareRecordsOnly = true}: HandleGlobalArgs) => {
if (!global.length) {
throw new DataOperatorException(
'An empty "values" array has been passed to the handleGlobal',
handleGlobal = async ({globals, prepareRecordsOnly = true}: HandleGlobalArgs) => {
if (!globals?.length) {
// eslint-disable-next-line no-console
console.warn(
'An empty or undefined "globals" array has been passed to the handleGlobal',
);
return [];
}
return this.handleRecords({
fieldName: 'id',
transformer: transformGlobalRecord,
prepareRecordsOnly,
createOrUpdateRawValues: getUniqueRawsBy({raws: global, key: 'id'}),
createOrUpdateRawValues: getUniqueRawsBy({raws: globals, key: 'id'}),
tableName: GLOBAL,
});
};